btrfs-progs: check: auto-detect chunk level when --chunk-root is specified #1037
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam900710
force-pushed
the
check_chunk_root
branch
from
a71760d to
9730f20
Compare
…ified [BUG] There is a bug report that, when using --chunk-root option, if the specified chunk root tree block has a different level than the one in the super block, btrfs check will reject the run: ERROR: root [3 0] level 0 does not match 1 ERROR: cannot read chunk root ERROR: cannot open file system Opening filesystem to check... [CAUSE] During btrfs_setup_chunk_tree_and_device_map(), although it accepts a @chunk_root_bytenr parameter, it still uses the chunk root level from the super block. Thus if the provided chunk root is at a different level, it will still be rejected. [FIX] Read out the tree block at @chunk_root_bytenr, and use the level from the tree block instead. Link: https://lore.kernel.org/linux-btrfs/CAKZK7uxiRmDxk-1goC4yj7QZPSmL-=GAoAuF=OdekbSNVrG8fg@mail.gmail.com/ Signed-off-by: Qu Wenruo <[email protected]>
adam900710
force-pushed
the
check_chunk_root
branch
from
9730f20 to
a223965
Compare
kdave
pushed a commit
that referenced
this pull request
Sep 25, 2025
…ified [BUG] There is a bug report that, when using --chunk-root option, if the specified chunk root tree block has a different level than the one in the super block, btrfs check will reject the run: ERROR: root [3 0] level 0 does not match 1 ERROR: cannot read chunk root ERROR: cannot open file system Opening filesystem to check... [CAUSE] During btrfs_setup_chunk_tree_and_device_map(), although it accepts a @chunk_root_bytenr parameter, it still uses the chunk root level from the super block. Thus if the provided chunk root is at a different level, it will still be rejected. [FIX] Read out the tree block at @chunk_root_bytenr, and use the level from the tree block instead. Pull-request: #1037 Link: https://lore.kernel.org/linux-btrfs/CAKZK7uxiRmDxk-1goC4yj7QZPSmL-=GAoAuF=OdekbSNVrG8fg@mail.gmail.com/ Signed-off-by: Qu Wenruo <[email protected]>
|
Merged to devel, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BUG]
There is a bug report that, when using --chunk-root option, if the specified chunk root tree block has a different level than the one in the super block, btrfs check will reject the run:
ERROR: root [3 0] level 0 does not match 1
ERROR: cannot read chunk root
ERROR: cannot open file system
Opening filesystem to check...
[CAUSE]
During btrfs_setup_chunk_tree_and_device_map(), although it accepts a @chunk_root_bytenr parameter, it still uses the chunk root level from the super block.
Thus if the provided chunk root is at a different level, it will still be rejected.
[FIX]
Read out the tree block at @chunk_root_bytenr, and use the level from the tree block instead.
Link: https://lore.kernel.org/linux-btrfs/CAKZK7uxiRmDxk-1goC4yj7QZPSmL-=GAoAuF=OdekbSNVrG8fg@mail.gmail.com/