Skip to content

Conversation

olamilekan000
Copy link
Contributor

Summary

change adds original resource version and UID to object before storing in the cache server

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #
#3631

Release Notes

Adds resource version and UID to object's annotation before persisting to the cache server

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 15, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2025
@olamilekan000 olamilekan000 requested a review from embik October 15, 2025 12:19
@olamilekan000
Copy link
Contributor Author

/retest

@olamilekan000 olamilekan000 force-pushed the persist-original-rv-in-cache-server branch 2 times, most recently from 3047616 to e0736fd Compare October 15, 2025 22:31
@kcp-ci-bot kcp-ci-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2025
@olamilekan000 olamilekan000 force-pushed the persist-original-rv-in-cache-server branch from e0736fd to a00e687 Compare October 15, 2025 22:32
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Oct 15, 2025

@olamilekan000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kcp-test-integration a00e687 link true /test pull-kcp-test-integration

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants