Skip to content

Conversation

@He1pa
Copy link
Contributor

@He1pa He1pa commented Mar 7, 2025

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 13712601301

Details

  • 38 of 62 (61.29%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 70.346%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/state.rs 38 62 61.29%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/state.rs 5 72.41%
Totals Coverage Status
Change from base Build 13630584295: -0.006%
Covered Lines: 52605
Relevant Lines: 74780

💛 - Coveralls

@He1pa He1pa merged commit 543b906 into main Mar 7, 2025
12 checks passed
@Peefy Peefy deleted the fix_fs_event_watcher branch March 7, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KCL LSP crashing: Too many open files

4 participants