Return false from AbstractApi::get() on empty response body

[phansys]

Fixes #274.

[kbsali]

the CI is broken, could you try to fix it?

[Art4]

This PR will fix the BC break. Thank you 👍

To fix the tests we also have to fix the expected return type in IssueRelation.php, see
https://github.com/kbsali/php-redmine-api/blob/v1.8.0/src/Redmine/Api/IssueRelation.php#L45

-        if (null === $ret) {
+        if (false === $ret) {

Also please see the requested changes.

[Art4]

Please remove the |null because this will never be the case.

[phansys]

json_decode() is able to return null if the decoded string is "null", but I think the API response will never print that.
Ref: https://3v4l.org/8sXS6.

[phansys]

To fix the tests we also have to fix the expected return type in IssueRelation.php, see

I saw that condition, that's in part why I couldn't spend more time in this PR yet.
Given that condition was introduced in version 0.3.0, I don't know if it was always the expected value near the failed responses.
I need to analyze how it was behaving prior to #257 in order to understand how it was working.
Even, since the changes in #257 were published in version 1.7.0, I wonder if we should provide a BC layer with a deprecation path for users who can be relying on this new behavior. Have you some concerns about this?

[Art4]

To be honest I have not deeply dived into the AbstractApi.php. With #257 I moved the parsing functionality from Client::get() to AbstractApi::get() and made the mistake to return null instead of false. I would keep it this old way returning false for BC instead of provide a deprecation path. Rewriting the AbstractApi could be a task after releasing v2.

[phansys]

Should I update the CHANGELOG explaining this change or it is updated when releasing?

[Art4]

@phansys Thank you very much. 👍
@kbsali This PR is ready for merge. After merge I will release v1.8.1 and port this PR into v2 branch.

[Art4]

Should I update the CHANGELOG explaining this change or it is updated when releasing?

I will do it before releasing v1.8.1. Thank you.

[kbsali]

Thanks @phansys ! 👍

[Art4]

@kbsali Can you please merge this? Or can I do it?

[kbsali]

sure, go ahead! :)