Skip to content

Changes made in #257 introduces a BC break #274

Closed
@phansys

Description

@phansys

Changes made in #257 introduces a BC break in the return value of AbstractApi::get().
Prior to these changes, if the response body was empty, get() was returning false, and currently it returns null.
Since this package lacks a exception oriented flow in front of HTTP responses ending in error codes (400~599), my implementation relies in the return values to determine the situation about a request.

Obviously the compatibility with PSR-18 is great, I'd just like to expose this situation in order to verify if these changes could respect BC.
Note that this is the only one BC break I've checked, since this is the first issue I encountered after updating the dependency.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions