Bug: Loading condition of "snacks-picker" provider seems to be broken

[ravsii]

The code that loads snacks at the moment looks like this (assuming I found the correct place):

leetcode.nvim/lua/leetcode/picker/init.lua

Lines 12 to 19 in 422b6be

	["snacks-picker"] = {
	name = "snacks",
	is_available = function()
	return pcall(function() ---@diagnostic disable-next-line: undefined-field
	assert(Snacks.config["picker"].enabled)
	end)
	end,
	},

but that doesn't seem to work anymore:

1. Snacks config doesn't have an enabled option
2. Picker seems to be always active and available via Snacks.picker.pickerFunc(), like Snacks.picker.files()

So in order to make it work, I had to manually set a non-existent setting, so it looks like this:

return {
  {
    "kawre/leetcode.nvim",
    dependencies = {
      "folke/snacks.nvim",
      -- other deps
    },
    opts = function()
      ---@diagnostic disable-next-line: inject-field
      Snacks.config.picker.enabled = true

      --- @module 'leetcode'
      return {
        ---@type lc.picker
        picker = { provider = "snacks-picker" },
 
        -- other options
      }
    end,
  },
}

Without Snacks.config.picker.enabled = true it doesn't work, but :lua Snacks.picker.files()

And if we check manually:

And with the mention above fix it's working as expected:

[kawre]

There is enabled option in snacks config -> https://github.com/folke/snacks.nvim?tab=readme-ov-file#-usage. Can you enable it and try again?

[ravsii]

Hi. I checked the actual code just in case, and there's no enabled as well https://github.com/folke/snacks.nvim/blob/main/lua/snacks/picker/config/defaults.lua#L65

Sorry, my weekdays are usually a bit busy, I'll try to make a minimal reproducible example when I have time and come back with the results in a couple of days

[ravsii]

So, I checked using this setup, and it really does work. My original config used picker options, but I haven't set enabled = true, as there's no such option, according to the snacks types.

Pics & Code

require("lazy").setup({
  spec = {
    {
      "kawre/leetcode.nvim",
      dependencies = {
        { "folke/snacks.nvim", opts = { picker = { enabled = true } } },
        "nvim-lua/plenary.nvim",
        "MunifTanjim/nui.nvim",
      },
      opts = { picker = { provider = "snacks-picker" } },
    },
  },
})

Weirdly enough, Snacks.picker even works with picker.enabled = false, so it doesn't seem to really do anything (anymore?). Maybe the readme is just outdated.

Pics & Code

require("lazy").setup({
  spec = {
    {
      "kawre/leetcode.nvim",
      dependencies = {
        { "folke/snacks.nvim", opts = { picker = { enabled = false } } },
        "nvim-lua/plenary.nvim",
        "MunifTanjim/nui.nvim",
      },
      opts = { picker = { provider = "snacks-picker" } },
    },
  },
})

---

The question is, should we rely on an option that's only mentioned once, or would it be better to rewrite the original function as pcall(Snacks.picker) or something similar?