Skip to content

Conversation

@WatskeBart
Copy link
Contributor

Added a tty compatible spinner.

spinner

@kattouf
Copy link
Owner

kattouf commented Jan 8, 2025

Thank you for the pull request, it looks nice!
Apologies, I don’t have a contribution guide yet, so I’ll mention it here: please add the prefix feat: to the pull request title. This is required for generating release changelogs.

After merging, I’ll update the documentation with the new animation type and a GIF when possible, and I’ll publish a release.

@WatskeBart WatskeBart changed the title Simple tty compatible spinner feat: Simple tty compatible spinner Jan 8, 2025
@WatskeBart
Copy link
Contributor Author

Thank you for the pull request, it looks nice! Apologies, I don’t have a contribution guide yet, so I’ll mention it here: please add the prefix feat: to the pull request title. This is required for generating release changelogs.

After merging, I’ll update the documentation with the new animation type and a GIF when possible, and I’ll publish a release.

Added the feat:

@kattouf kattouf merged commit 4052967 into kattouf:main Jan 9, 2025
5 checks passed
@kattouf
Copy link
Owner

kattouf commented Jan 9, 2025

@WatskeBart thanks for your contribution 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants