Support generic input #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to gradually convert the code to using generic source inputs, I rename the extensions of Swift files to disable them from building and focus on one file at a time. I do this instead of using an Xcode project, as Xcode just keeps crashing and giving errors that do not occur when opening this project as a swift package. Both Xcode 11.6 and Xcode 12 beta.
…String.
Replaced all
public func createInstructions(_ instructions: inout Instructions) throws {
with
public func createInstructions(_ instructions: inout ContiguousArray<Instruction<Input>>) throws {
as the former seemed to cause compiler crashes.
Some of them took too long for the compiler.
Cannot use just 5.3 on linux, and when using 5.3-DEVELOPMENT-SNAPSHOT-2020-08-08-a on macOS it cannot find XCTest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.