Fix test failure and improve escapeField function

[kamiazya]

This pull request fixes a test failure in the Lexer class and improves the escapeField function.

Additionally, the escapeField function has been refactored to handle common options and improve performance.

The occurrences utility has also been added to count the number of occurrences of a substring in a string. These changes address the issue #54 and improve the overall reliability and efficiency of the codebase.

Summary by CodeRabbit

• New Features

  • Enhanced filtering capability with validation checks.
  • Improved field escaping logic for data processing.

• Refactor

  • Optimized substring occurrence calculations with caching.

fix #54

[changeset-bot]

🦋 Changeset detected

Latest commit: 9589a47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
web-csv-toolbox	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Warning

Rate Limit Exceeded

@kamiazya has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 14 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 878ba57 and 9589a47.

Walkthrough

The codebase has been updated to enhance input validation and string handling. A new import for an assertion function has been added to ensure common options are correct, with error handling added during filter operations. Additionally, string escaping logic now leverages a new utility function to count substring occurrences, optimizing the decision-making process for when to quote fields.

Changes

File Path	Change Summary
.../__tests__/helper.ts, .../internal/Lexer.spec.ts	Added import for assertCommonOptions, modified filter method, and logic for handling empty and escaped fields.
.../internal/escapeField.ts	Integrated occurrences utility for quoting logic.
.../internal/utils/occurrences.ts	Added function for counting substring occurrences with regex cache.

🐰🌟
To the fields of code, we hop and leap,
With assertions strong and escapes deep.
Counting occurrences, all in a row,
Ensuring our data, perfectly stowed.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e2ba503 and 0d515a2.

Files selected for processing (3)

• src/lib/tests/helper.ts (2 hunks)
• src/lib/internal/escapeField.ts (2 hunks)
• src/lib/internal/utils/occurrences.ts (1 hunks)

Additional comments: 3

src/lib/internal/utils/occurrences.ts (1)

• 11-21: The implementation of the occurrences function is correct and efficient, using a cache for compiled regular expressions to improve performance.

src/lib/internal/escapeField.ts (1)

• 66-85: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-82]

The refactoring of the escapeField function to use the occurrences utility is correct and aligns with the PR's objective to improve functionality and performance.

src/lib/__tests__/helper.ts (1)

• 154-161: The integration of assertCommonOptions within the FC namespace's commonOptions function is correct and provides error handling as intended by the PR.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0d515a2 and 878ba57.

Files selected for processing (1)

• src/lib/internal/Lexer.spec.ts (1 hunks)