Improve text of some errors #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ossible Tests that need to be updated: [info] - expr_unknown_method1 *** FAILED *** [info] [expr_unknown_method1.ksy: /instances/foo/value: [info] error: don't know how to call method 'frobnicate' of object type 'byte array' [info] ] [info] did not equal [info] [expr_unknown_method1.ksy: /instances/foo/value: [info] error: don't know how to call method 'frobnicate' of object type 'CalcBytesType' [info] ] (SimpleMatchers.scala:34) [info] - expr_unknown_method2 *** FAILED *** [info] [expr_unknown_method2.ksy: /instances/foo/value: [info] error: don't know how to call method 'frobnicate' of object type 'byte array' [info] ] [info] did not equal [info] [expr_unknown_method2.ksy: /instances/foo/value: [info] error: don't know how to call method 'frobnicate' of object type 'CalcBytesType' [info] ] (SimpleMatchers.scala:34) [info] - io_on_bytes *** FAILED *** [info] [io_on_bytes.ksy: /instances/one_in_foo/io: [info] error: don't know how to call method '_io' of object type 'byte array' [info] ] [info] did not equal [info] [io_on_bytes.ksy: /instances/one_in_foo/io: [info] error: don't know how to call method '_io' of object type 'BytesLimitType(IntNum(100),None,false,None,None)' [info] ] (SimpleMatchers.scala:34)
Mingun
added a commit
to Mingun/kaitai_struct_tests
that referenced
this pull request
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves text of errors and partially implements this TODO:
In all situations where MethodNotFoundErrorWithArg could be thrown it is thrown. Also I added new
MethodTypeArgfor kaitai stream type.PR for updating tests: kaitai-io/kaitai_struct_tests#129