Skip to content

Conversation

@BobDu
Copy link
Contributor

@BobDu BobDu commented Aug 13, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@BobDu BobDu requested review from a team as code owners August 13, 2025 03:53
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Aug 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi BobDu! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean changed the title FE: Add more topic time to retain data quick selection buttons FE: Topics: Add more retain options Aug 15, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels Aug 15, 2025
@Haarolean Haarolean added this to the 1.4 milestone Aug 15, 2025
@Haarolean
Copy link
Member

@BobDu hi, thanks for your PR! Please take a look at the failing tests

@BobDu
Copy link
Contributor Author

BobDu commented Aug 18, 2025

@BobDu hi, thanks for your PR! Please take a look at the failing tests

done

@Haarolean Haarolean merged commit c1d1e62 into kafbat:main Aug 19, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.4 Aug 19, 2025
@Haarolean
Copy link
Member

@BobDu Thanks for your first PR to kafbat ui! 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants