update some outdated packages #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilypi
approved these changes
May 12, 2022
larskuhtz
commented
Jun 2, 2022
pact.cabal
Outdated
| , trifecta >= 2.1 | ||
| , unordered-containers >= 0.2.7.2 && <= 0.2.15.0 | ||
| , unordered-containers >= 0.2.7.2 && <= 0.2.20 |
There was a problem hiding this comment.
This change affects JSON serialization and breaks backward compatibility of hashes, even with hashable-1.3.0.0. :-(
There was a problem hiding this comment.
unordered-containers-2.16.0.0 breaks backward compatibility. I think it is this change the causes it.
larskuhtz
commented
Jun 2, 2022
pact.cabal
Outdated
| , neat-interpolation >= 0.4 | ||
| , optparse-applicative >= 0.12.1.0 && < 0.16 | ||
| , optparse-applicative >= 0.12.1.0 && < 0.18 | ||
| , sbv >= 8.8 && <9.0 |
There was a problem hiding this comment.
sbv-9.0 seems to work fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess, I'll give up on my crusade against meaningless upper bounds in cabal files... Everybody seems to be fine with this kind of PRs...