Skip to content

Properly stop containerd component when startup fails #6462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Properly stop containerd component when startup fails #6462

wants to merge 1 commit into from

Conversation

@twz123
Copy link
Member

@twz123 twz123 commented Oct 2, 2025

Description

Previously, the drop-in watcher and the supervisor weren't stopped properly when the Start method failed later on.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@twz123 twz123 marked this pull request as ready for review October 2, 2025 08:29
@twz123 twz123 requested review from a team as code owners October 2, 2025 08:29
@twz123 twz123 requested review from kke and ncopa October 2, 2025 08:29
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

This pull request has merge conflicts that need to be resolved.

@twz123
Properly stop containerd component when startup fails
4f7e8cb 
Previously, the drop-in watcher and the supervisor weren't stopped
properly when the Start method failed later on.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 force-pushed the properly-stop-containerd branch from cc8dd02 to 4f7e8cb Compare October 23, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncopa ncopa Awaiting requested review from ncopa ncopa is a code owner automatically assigned from k0sproject/k0s-maintainers

@kke kke Awaiting requested review from kke kke is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/worker bug Something isn't working component/containerd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@twz123