Add cgroup auto-detection for kubelet & containerd #6298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces cgroups auto-detection to select the driver (systemd/cgroupsfs) based on the operating environment. The auto-detection respects an existing configuration on the node, so which ever driver was used will be still used after upgrade. This ensures we're not gonna change the driver "in-flight" as that would probably break containers and pods. The scope has been solely the driver detection, so what ever hard-coded, and non-optimal, cgroups have been used will still be used by default. Signed-off-by: Jussi Nummelin <[email protected]>
|
This pull request has merge conflicts that need to be resolved. |
|
The PR is marked as stale since no activity has been recorded in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces cgroups auto-detection to select the driver (systemd/cgroupsfs) based on the operating environment. The auto-detection respects an existing configuration on the node, so which ever driver was used will be still used after upgrade. This ensures we're not gonna change the driver "in-flight" as that would probably break containers and pods.
The scope has been solely the driver detection, so what ever hard-coded, and non-optimal, cgroups have been used will still be used by default.
Fixes #6278
Type of change
This is borderline a bug fix and a feature. 😂
How Has This Been Tested?
Checklist