chore: pagobancomat card scheme regex addition #600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanskar2001
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
as code owners
|
Review changes with |
| { | ||
| issuer: "PagoBancomat", | ||
| pattern: %re( | ||
| "/^(10051\d{5}|10053\d{5}|10108\d{5}|10150\d{5}|10258\d{5}|10300\d{5}|10309\d{5}|20083\d{5}|20084\d{5}|20085\d{5}|20089\d{5}|30150\d{5}|30190\d{5}|30320\d{5}|30430\d{5}|30439\d{5}|30480\d{5}|30583\d{5}|30589\d{5}|30590\d{5}|30620\d{5}|30670\d{5}|30690\d{5}|30750\d{5}|30830\d{5}|30836\d{5}|30870\d{5}|31040\d{5}|31110\d{5}|31240\d{5}|31260\d{5}|31270\d{5}|31380\d{5}|31580\d{5}|31599\d{5}|31850\d{5}|32040\d{5}|32050\d{5}|32115\d{5}|32390\d{5}|32400\d{5}|32420\d{5}|32440\d{5}|32500\d{5}|32630\d{5}|32681\d{5}|32682\d{5}|32685\d{5}|32968\d{5}|33320\d{5}|33870\d{5}|33990\d{5}|34000\d{5}|34029\d{5}|34030\d{5}|34253\d{5}|34310\d{5}|34400\d{5}|34420\d{5}|34880\d{5}|34938\d{5}|35000\d{5}|35899\d{5}|35980\d{5}|35990\d{5})$/" |
There was a problem hiding this comment.
can we put one comment what this regex is doing?
And please check in multiple browsers for this regex.
PritishBudhiraja
changed the title
PritishBudhiraja
temporarily deployed
to
Testing
GitHub Actions
Inactive
PritishBudhiraja
added
the
Ready for Review
PritishBudhiraja
had a problem deploying
to
Testing
GitHub Actions
Failure
|
Closing this when we will need will open again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
How did you test it?
Checklist
npm run re:build