Skip to content

Conversation

bnavigator
Copy link
Contributor

openapi-core had a severe API change: create_spec now returns a SpecPath instead of Spec.

In order to not have to pin to < 0.14 in openSUSE Tumleweed, here is a patch dealing with both APIs.

spec['paths'] throws openapi_core.schema.paths.exceptions.InvalidPath in openapi-core 0.13.8, which is not importable in 0.14. The OpenAPIError is a common exception for the two versions.

Another possibility would be to just require ~=0.14.0 and always get a SpecPath.

@welcome
Copy link

welcome bot commented Aug 16, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2021

Codecov Report

Merging #198 (ba5873e) into master (028cec5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files          27       27           
  Lines        1993     1993           
=======================================
  Hits         1554     1554           
  Misses        439      439           
Impacted Files Coverage Δ
jupyterlab_server/tests/utils.py 72.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028cec5...ba5873e. Read the comment docs.

@bnavigator
Copy link
Contributor Author

@blink1073
Copy link
Contributor

Thanks for catching this!

Another possibility would be to just require ~=0.14.0 and always get a SpecPath

That sounds good

@blink1073 blink1073 added this to the 2.7 milestone Aug 16, 2021
@bnavigator
Copy link
Contributor Author

Another possibility would be to just require ~=0.14.0 and always get a SpecPath

That sounds good

Updated

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 01cf41e into jupyterlab:master Aug 17, 2021
@welcome
Copy link

welcome bot commented Aug 17, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants