added terminado_settings #1453
added terminado_settings #1453
Conversation
| "Jupyter notebook uses.") | ||
|
|
||
| terminado_settings = Dict(config=True, | ||
| help='Supply overrides for terminado. Currently only supports "shell_command".') |
There was a problem hiding this comment.
Are there other things you envisage putting in here? Would it be simpler to have terminals_shell_command as a configurable thing by itself?
There was a problem hiding this comment.
I didn't want to add anything I didn't need right now. I could see someone wanting to add environment variables or , for instance. It also seems to me that it is also consistent with tornado_settings.
There was a problem hiding this comment.
It's a reasonable enough approach. I think tornado_settings is a bit of a special case because there are so many things that might go in there, but I'd be happy either way. Let's give others a chance to look at this.
|
Since you made this PR from your master branch, it looks like it's pulling in work from other PRs. Do you want to get this back to just the proposed change? |
|
I'll resubmit. Not sure how to remove commits from an existing PR. |
3 participants
Specifically, to support overriding terminado's shell_command with something that allows flags. We are using JupyterHub, and it's important for our users to get a clean shell (bash --login).