Respect keyboard manager state in clipboard logic #1342
Conversation
jdfreder
force-pushed
the
clipboardRespect
branch
from
3e399a5 to
72eeb99
Compare
|
👍 |
|
Arg, the test failures seem unrelated. |
|
Looks OK to me. We were already checking it on paste, but it makes sense to do it on copy as well. I've just restarted one of the failing test jobs to see if it still fails. It didn't sound like anything related to this, but it was the same failure between Python versions, which makes it seem like something real. |
|
It's not related to this PR, but it is a real failure. The only thing I've tracked down is that casperjs is 1.1.0-beta5 in the last success, and 1.1.0 where it's failing. I have reproduced the failure with current master. |
|
I opened #1348 to pin casper to the last known-good version, in case that's really the issue. |
|
Merging, since the failures aren't related to this PR, and with #1348 in, master should still pass. |
|
Thanks! |
|
Thank you for looking into this @minrk ! @takluyver yeah, there was a dialog with a text area that was designed to be copied from in ipywidgets that wasn't working. Paste was though ;) |
4 participants
cc @takluyver @Carreau
closes #1341