Use loop.create_task with interact() #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing coroutines directly to asyncio.wait is deprecated since
Python 3.8, as it leads to confusing behavior:
https://docs.python.org/3.10/library/asyncio-task.html#asyncio-example-wait-coroutine
In Python 3.11, wait() no longer accepts coroutines and
must be given Tasks.
|
I can confirm this actually works. |
|
Thanks @encukou. |
|
OK, here's a bigger change: all the code that needs the loop moved to an This makes several |
davidbrochart
requested changes
Jun 22, 2022
|
Is it OK to drop compatibility with Python 3.6? |
|
Yes it is, do you also want to update |
encukou
commented
Jun 22, 2022
davidbrochart
approved these changes
Jun 22, 2022
|
Thanks a lot @encukou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing coroutines directly to asyncio.wait is deprecated since Python 3.8, as it leads to confusing behavior.
In Python 3.11,
wait()will no longer accept coroutines and must be given Tasks.