This repository was archived by the owner on Jan 22, 2018. It is now read-only.
Add stub for about plugin #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
blink1073
commented
Mar 2, 2016
blink1073
commented
Member
|
Cool! |
Member
|
Nice! Would one have to update the plugin directly here or would we be able to change the text over on the notebook side? |
Contributor
Author
|
The running theory has been that the notebook repo will essentially become a server only, with just the bootstrapping code. |
Member
|
I mean to say that following on with a PR for "About" text - does it belong here or when integrated into the notebook? |
Contributor
Author
|
I meant everything should be here, the notebook side only assembles plugins, it does not contribute any. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.