Skip to content

Conversation

@rkdarst
Copy link
Contributor

@rkdarst rkdarst commented Aug 4, 2019

  • This would have made updating all package versions easier, so doing it now.
  • Differences I noticed:
    • r-notebook and datascience-notebook are almost identical
    • r-notebook has r-odbc and unixodbc, datascience-notebook doesn't
    • all-spark-notebook has r-ggplot2 explicitely added and version
      pinned. The others pull it in but isn't version pinned.
  • I'm conflicted as to if I should skip the CI on this, but since it's
    not pure text changes I won't.

@parente
Copy link
Member

parente commented Aug 6, 2019

The build is failing with /bin/sh: 1: r-htmltools=0.3*: not found which is interesting considering it was in the package list before this sorting change. ]

Typo? Package change upstream?

@rkdarst
Copy link
Contributor Author

rkdarst commented Aug 6, 2019

It was the && endings that also got sorted (despite remembering to handle them before I started). I just moved them to a new line with a force-push.

CI wins... obviously!

@parente parente merged commit 2ce7c06 into jupyter:master Aug 10, 2019
@rkdarst rkdarst deleted the sort-installs branch August 11, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants