-
Notifications
You must be signed in to change notification settings - Fork 3k
Upgrade Python in scipy-notebook to 3.7 #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Python in scipy-notebook to 3.7 #778
Conversation
|
Build fails consistently after 10 minutes of solving conda dependencies in the tensorflow image with no output. We can try merging and see what happens with the build on Docker Cloud, and revert if it causes trouble there. |
a9806d2 to
fa09b38
Compare
Actually I think Tensorflow hasn't officially supported Python 3.7 yet. We can track the issue here. Let's wait for Tensorflow 1.13 to be released before merging my PR. |
|
my understanding is that tensorflow was released as 1.13 a short while ago |
|
Resolved the merge conflict using the nice new GH editor for that, and kicked off a build to see where we stand. |
Next step is for the PR to update versions. |
|
Hey folks; I'd love to see this come through, is there anything I can do to help out on this one ? |
|
@parmentelat The work to be done to get a conda-forge build of tensorflow 1.13 w/ Python 3.7 support is tracked in conda-forge/tensorflow-feedstock#66. You can give that a read and see if there's a place where you can lend a hand. |
|
The referenced PR was merged 2 days ago ✨ |
93f1a29 to
f067ea1
Compare
|
Rebased on master and rebuilding with tf 1.13 |
|
Build is green. Thanks for the contributions and patience everyone! |
This PR pins the Python version to prevent Conda from downgrading (e.g. from 3.7 to 3.6). It also updates two packages,
numbaandh5py, to make them compatible with Python 3.7. Fixes issue #768