-
Notifications
You must be signed in to change notification settings - Fork 3k
Upgrading Spark->3.3,Hadoop->3,Scala->2.13,Java->17 #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mathbunnyru Let me know what you think we should do with spylon-kernel which is causing tests to fail. |
|
Almond dont support spark 3.x almond-sh/almond#929 And you can remove from line 51 to 55 |
mathbunnyru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest doing it this way:
-
Remove scala in a separate PR first. We can't keep using software which is not updated and starts breaking things. If possible, it would be nice to have a replacement, like
almondor sth else (whenalmondor something similar is working in our environment). -
Then we can merge this PR.
|
@Bidek56 Will you do this? If not than I can do it. If you will try I can help you, just ping me.. |
|
I have created a branch for this upgrade just to test it. docker imgae for pyspark I test the scala kernel and only get |
|
Just a note that this PR will break Build an Image with a Different Version of Spark for Spark < 3.2 since Apache was not providing tgz files with Scala version appended. |
mathbunnyru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bidek56 as you mentioned, could you please update the docs, so they will work after this change is merged?
|
I merged removing |
|
The build has failed because it is running Spark 3.2.1 not 3.3. The error message references Spark 3.2.1 but in the container using the PR code, I see Spark 3.3.0 and my tests pass |
|
@Bidek56 this happens because when building After I merge this PR, I think we will be able to easily merge your PR. |
|
Yes, you don't have to do anything with the tests. docker-stacks/pyspark-notebook/Dockerfile Lines 51 to 55 in 61b20aa
|
|
@Bidek56 could you merge master once again? |
mathbunnyru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor documentation comments only.
Co-authored-by: Ayaz Salikhov <[email protected]>
Co-authored-by: Ayaz Salikhov <[email protected]>
Clarifying OpenJDK comments
for more information, see https://pre-commit.ci
mathbunnyru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this one when tests pass.
Thank you for your contribution @Bidek56 👍
|
All checks have passed. Excellent! |
Describe your changes
Upgrading:
Breaking change: spylon-kernel not longer works since the package is no longer maintained.
For anyone looking for a Scala kernel, I would suggest looking at Almond
Checklist (especially for first-time contributors)