Skip to content

Conversation

@LustigePerson
Copy link
Contributor

@LustigePerson LustigePerson commented Jul 21, 2020

texlive-fonts-extra seems not be be a requirement of nbconvert.
Reduces the image size by ~ 1.3 GB which will affect all images that build on the minimal-notebook image.

REPOSITORY                    TAG                 IMAGE ID            CREATED             SIZE
minimal-notebook-nofonts      latest              9641ee9dd31c        3 minutes ago       1.7GB
minimal-notebook              latest              e23d7794a410        14 minutes ago      3.01GB

I opened a issues questioning if there is any reason to keep this package. See also the comment here in PR 1013.
So this PR closes #1129.

@LustigePerson LustigePerson marked this pull request as ready for review July 21, 2020 08:40
@romainx romainx self-requested a review July 21, 2020 09:19
Copy link
Collaborator

@romainx romainx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

As I said in #1129, it's OK for me. Please note that a test checks that nbconvert is working properly to convert notebook to PDF and HTML.

@pytest.mark.parametrize("format", ["html", "pdf"])
def test_nbconvert(container, format):
"""Check if nbconvert is able to convert a notebook file"""

However I may be not aware of other use cases, usages.

Best

@romainx romainx added the status:Ready to Merge PR reviewed, up-to-date, and ready to merge label Jul 21, 2020
@parente
Copy link
Member

parente commented Jul 30, 2020

The fonts extra package has been present in the minimal image since its original definition 5 years ago. I very likely seeded the initial list of apt packages based on brief trial and error and what we had in the all-in-one tmpnb image at the time.

I think the space savings is worth an attempt at removing it. If there is outcry, we can discuss and evaluate options (e.g., recipe, restoring it).

@parente parente merged commit 1a66dd3 into jupyter:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:Ready to Merge PR reviewed, up-to-date, and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we need texlive-fonts-extra in the minimal-notebook?

3 participants