Skip to content

Ignore NoSuchFileException in @TempDir cleanup #3667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Ignore NoSuchFileException in @TempDir cleanup #3667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c371bf5
Ignore NoSuchFileException in TempDirectory Cleanup
gilday Jan 30, 2024
ed397b4
📝 Update Release Notes
gilday Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions documentation/src/docs/asciidoc/release-notes/release-notes-5.11.0-M1.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ repository on GitHub.
*** The same applies to other types of test methods (`@TestFactory`,
`@ParameterizedTest`, etc.) as well as lifecycle methods (`@BeforeAll`,
`@AfterAll`, `@BeforeEach`, and `@AfterEach`).
* `TempDir` suppresses `NoSuchFileException` when deleting files that may have been deleted
by another thread or process.

[[release-notes-5.11.0-M1-junit-jupiter-deprecations-and-breaking-changes]]
==== Deprecations and Breaking Changes
Expand Down
3 changes: 3 additions & 0 deletions junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/extension/TempDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,9 @@ public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs) {

@Override
public FileVisitResult visitFileFailed(Path file, IOException exc) {
if (exc instanceof NoSuchFileException) {
return CONTINUE;
}
// IOException includes `AccessDeniedException` thrown by non-readable or non-executable flags
resetPermissionsAndTryToDeleteAgain(file, exc);
return CONTINUE;
Expand Down