Can no longer use `#` as delimiter with `@CsvSource` and `@CsvFileSource`

[hwellmann]

Some of our tests started failing after upgrading from JUnit Jupiter 5.13.4 to JUnit Jupiter 6.0.0.

Steps to reproduce

Example:

@ParameterizedTest
@CsvSource(delimiterString = "#", textBlock = """
    foo # bar
    """)
void csv(String a, String b) {
}

Fails with an exception:

Caused by: java.lang.IllegalArgumentException: Control characters must differ (fieldSeparator=#, quoteCharacter=', commentCharacter=#)

Perhaps there should be an attribute in @CsvSource to override the comment character.

[marcphilipp]

We should check if the pre-6.0 implementation based on univocity-parsers supported comments at all. If not, maybe we can disable comment support in FastCSV to fix the regression.

@vdmitrienko Do you have time to take a look?

[vdmitrienko]

@vdmitrienko Do you have time to take a look?

Yep, will take a look today.

[sbrannen]

Comment support is a first-class feature for text blocks with @CsvSource, like in this example from the User Guide.

@ParameterizedTest
@CsvSource(delimiter = '|', quoteCharacter = '"', textBlock = """
    #-----------------------------
    #    FRUIT     |     RANK
    #-----------------------------
         apple     |      1
    #-----------------------------
         banana    |      2
    #-----------------------------
      "lemon lime" |     0xF1
    #-----------------------------
       strawberry  |    700_000
    #-----------------------------
    """)
void testWithCsvSource(String fruit, int rank) {
    // ...
}

[sbrannen]

Modifying the example from the User Guide as follows causes it to fail with the same exception in this issue's description.

@ParameterizedTest
@CsvSource(delimiter = '#', quoteCharacter = '"', textBlock = """
	#-----------------------------
	#    FRUIT     #     RANK
	#-----------------------------
	     apple     #      1
	#-----------------------------
	     banana    #      2
	#-----------------------------
	  "lemon lime" #     0xF1
	#-----------------------------
	   strawberry  #    700_000
	#-----------------------------
	""")
void test(String fruit, int rank) {
	// ...
}