Add QP complementarity test #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Oct 9, 2019
Member
odow
left a comment
odow
left a comment
There was a problem hiding this comment.
Ideally, we would write this in the compact form without auxiliary variables.
Contributor
Author
|
I understand. I still have to bridge Knitro then. |
Codecov Report
@@ Coverage Diff @@
## od/complements #918 +/- ##
==================================================
+ Coverage 95.21% 95.22% +0.01%
==================================================
Files 82 82
Lines 8770 8794 +24
==================================================
+ Hits 8350 8374 +24
Misses 420 420
Continue to review full report at Codecov.
|
Member
|
You should test the test with a |
Contributor
Author
|
Just a question, however. You mentioned earlier:
Shouldn't we test this feature as well? |
blegat
reviewed
Oct 10, 2019
odow
reviewed
Oct 10, 2019
odow
added a commit
that referenced
this pull request
Oct 21, 2019
* Add Complements set * Update docstring * Fix test/Test/Tests.jl * Update docstrings * Fix optimal_status * Update examples in docstring * More updates to docstring * Add Complements to docs * Add AbstractVectorFunction to docs * Tweak definition of complements * Add QP complementarity test (#918) * Test: add QP complementarity test * Add Mock test for QP complementarity test * Fix with comments in PR#918 * Update nlp.jl * Re-word definition of Complements and break tests into CP and MPCC * Update example in Complements docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stay at your disposal if you want to add other MPEC tests inside MOI