Skip to content

fix handling of warnOnSpreadAttributes being false #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ljharb merged 1 commit into from
Apr 7, 2021
Merged

fix handling of warnOnSpreadAttributes being false #2953

ljharb merged 1 commit into from
Apr 7, 2021

Conversation

@Nokel81
Copy link
Contributor

@Nokel81 Nokel81 commented Mar 24, 2021

fixes #2952

ljharb
ljharb approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@codecov-io
Copy link

codecov-io commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #2953 (6b6a14a) into master (7ce9106) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2953   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         110      110           
  Lines        7256     7256           
  Branches     2643     2643           
=======================================
  Hits         7081     7081           
  Misses        175      175
Impacted Files Coverage Δ
lib/rules/jsx-no-target-blank.js 94.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce9106...6b6a14a. Read the comment docs.

@ljharb ljharb merged commit 6b6a14a into jsx-eslint:master Apr 7, 2021
@Nokel81 Nokel81 deleted the issue-2952 branch April 7, 2021 16:19
@Nokel81
Copy link
Contributor Author

Nokel81 commented Apr 7, 2021

I too was glad that it was such a simple fix.

@mrtnzlml mrtnzlml mentioned this pull request Apr 9, 2021
Merged
@gone-skiing gone-skiing mentioned this pull request Apr 9, 2021
Merged
@crupest crupest mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jsx-no-target-blank fails when spread props is before target even when warnOnSpreadAttributes is false

3 participants

@Nokel81 @codecov-io @ljharb