Skip to content

Fix static propTypes handling in no-typos #1827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2018
Merged

Fix static propTypes handling in no-typos #1827

merged 2 commits into from
Jun 15, 2018

Conversation

alexzherdev
Copy link
Contributor

Resolves #1677

ljharb
ljharb approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add duplicate test cases that do not use babel-eslint (ie, using Component.propTypes =)?

@ljharb ljharb added the bug label Jun 14, 2018
@ljharb ljharb requested review from yannickcr, lencioni and EvHaus June 14, 2018 16:22
@ljharb
Copy link
Member

ljharb commented Jun 14, 2018

(if those test cases already exist - because the bug is about class fields - then my bad)

@alexzherdev
Copy link
Contributor Author

@ljharb I think these two cases are what you're looking for? I don't think these need babel-eslint so I'll remove it.
https://github.com/yannickcr/eslint-plugin-react/blob/2a674b03b620791f724ebd6538916524a0e58efb/tests/lib/rules/no-typos.js#L926-L950

@ljharb
Copy link
Member

ljharb commented Jun 14, 2018

That’s be great - generally it’s nice to have every test case repeated, one for each parser.

alexzherdev
alexzherdev commented Jun 15, 2018
View reviewed changes
lib/rules/no-typos.js
@@ -45,7 +45,7 @@ module.exports = {
let propTypesPackageName = null;
let reactPackageName = null;

function checkValidPropTypeQualfier(node) {
function checkValidPropTypeQualifier(node) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone put typos in no-typos so I can fix typos while I fix no-typos.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0ca36be035e2c8c79d6af4543c7a6990

@alexzherdev alexzherdev mentioned this pull request Jun 15, 2018
Closed
EvHaus
EvHaus approved these changes Jun 15, 2018
View reviewed changes
Copy link
Collaborator

@EvHaus EvHaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/rules/no-typos.js
@@ -45,7 +45,7 @@ module.exports = {
let propTypesPackageName = null;
let reactPackageName = null;

function checkValidPropTypeQualfier(node) {
function checkValidPropTypeQualifier(node) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0ca36be035e2c8c79d6af4543c7a6990

@ljharb ljharb merged commit 48e386d into jsx-eslint:master Jun 15, 2018
@alexzherdev alexzherdev deleted the 1677-no-typos-static-proptypes branch June 29, 2018 17:03
@dependencies dependencies bot mentioned this pull request Jul 9, 2018
Closed
@dependencies dependencies bot mentioned this pull request Aug 1, 2018
Open
This was referenced Sep 22, 2018
Open
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Open
Open
Merged
@renovate renovate bot mentioned this pull request Oct 30, 2018
Merged
@dependencies dependencies bot mentioned this pull request Nov 1, 2018
Closed
This was referenced Nov 4, 2018
Closed
Merged
Closed
This was referenced Nov 23, 2018
Open
Merged
@renovate renovate bot mentioned this pull request Dec 5, 2018
Closed
1 task
@mesosphere-web mesosphere-web mentioned this pull request Dec 19, 2018
Closed
1 task
@renovate-bot renovate-bot mentioned this pull request Dec 19, 2018
Merged
1 task
This was referenced Dec 21, 2018
Open
Merged
Merged
Closed
Merged
Closed
This was referenced Jan 2, 2019
Merged
Closed
Open
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@EvHaus EvHaus EvHaus approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

@lencioni lencioni Awaiting requested review from lencioni

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexzherdev @ljharb @EvHaus