Fix static propTypes handling in no-typos #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Jun 14, 2018
|
(if those test cases already exist - because the bug is about class fields - then my bad) |
|
@ljharb I think these two cases are what you're looking for? I don't think these need |
|
That’s be great - generally it’s nice to have every test case repeated, one for each parser. |
alexzherdev
commented
Jun 15, 2018
| @@ -45,7 +45,7 @@ module.exports = { | |||
| let propTypesPackageName = null; | |||
| let reactPackageName = null; | |||
|
|
|||
| function checkValidPropTypeQualfier(node) { | |||
| function checkValidPropTypeQualifier(node) { | |||
There was a problem hiding this comment.
Someone put typos in no-typos so I can fix typos while I fix no-typos.
EvHaus
approved these changes
Jun 15, 2018
| @@ -45,7 +45,7 @@ module.exports = { | |||
| let propTypesPackageName = null; | |||
| let reactPackageName = null; | |||
|
|
|||
| function checkValidPropTypeQualfier(node) { | |||
| function checkValidPropTypeQualifier(node) { | |||
ghost
mentioned this pull request
ghost
mentioned this pull request
This was referenced Sep 22, 2018
Closed
ghost
mentioned this pull request
This was referenced Nov 4, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Dec 21, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1677