-
Notifications
You must be signed in to change notification settings - Fork 348
Add sidebar navigation to introduction page #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There seems to be some issues with the first sections:
Maybe it could be fixed by using different values for threshold and rootMargin in the IntersectionObserver. 🤔 Screen.Recording.2025-08-06.at.12.59.17.PM.mov |
Looks like we can move around the value for rootMargin to fix that. Thanks @christiansamaniego-okta ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the previous issue @javiert-okta. Looks awesome!
Nit pick: A couple very minor things I'll leave as optional:
- Make the divider match the color of the divider at the top of the page (below the "Introduction to JSON Web Tokens" heading)
- Adding some margin at the bottom so that the divider doesn't touch the component at the bottom
Nice suggestions @christiansamaniego-okta. I addressed both of them, take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job!
This PR adds a sidebar navigation to the introduction page with the following features:
https://next-jwt-8ftcynofz-okta-3f38a12f.vercel.app/introduction#how-json-web-tokens-work