Skip to content

fixed regex for $id in core metaschema #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

fixed regex for $id in core metaschema #804

merged 1 commit into from
Sep 18, 2019

Conversation

gregsdennis
Copy link
Member

Found this while testing when the meta-schema didn't validate its own $id. If we prefer something else, that's fine, just probably test that it works first.

Relequestual
Relequestual approved these changes Sep 18, 2019
View reviewed changes
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be copied to the website, as that's where people generally access the meta-schema.

@gregsdennis gregsdennis merged commit b47f567 into json-schema-org:master Sep 18, 2019
Relequestual added a commit to json-schema-org/json-schema-org.github.io that referenced this pull request Sep 18, 2019
@Relequestual
Merge pull request #291 from gregsdennis/master
e204f3a 
Update draft/2019-09 submodule IAW json-schema-org/json-schema-spec/pull/804
@karenetheridge karenetheridge mentioned this pull request Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Relequestual Relequestual Relequestual approved these changes

@handrews handrews Awaiting requested review from handrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregsdennis @Relequestual