Wrap the entire core vocabulary inside the core vocab section. #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really, it should be like any other vocabulary, grouped into a single section. The text will get some further tweaking to fix issues related to having to introduce a vocabulary before the concept of vocabularies are fully introduced.
A few minor clarifications are added, including a RECOMMENDATION against using "$" as the first character of extension keywords. The paragraph about bug-fix meta-schema and vocabulary URIs seemed out of place, and worth calling out more clearly, so it became its own section.
philsturgeon
approved these changes
Aug 16, 2019
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: There are two commits here. The first commit only moves the core vocabulary section out a level, nesting the various core keyword definition sections under it. The second commit has several minor changes to improve flow in the new layout. It will be a lot easier if you look a the diffs separately for each commit- the change is quite minor when examined that way.
Really, Core should be like any other vocabulary, grouped into a single section.
A few minor clarifications are added, including a RECOMMENDATION
against using "$" as the first character of extension keywords.
The paragraph about bug-fix meta-schema and vocabulary URIs seemed
out of place, and worth calling out more clearly, so it became
its own section.