Skip to content

Add missing closing curly brace to D.2. example #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing closing curly brace to D.2. example #1162

wants to merge 1 commit into from

Conversation

jviotti
Copy link
Member

@jviotti jviotti commented Dec 29, 2021

We also remove the trailing comma.

Signed-off-by: Juan Cruz Viotti [email protected]

We also remove the trailing comma.

Signed-off-by: Juan Cruz Viotti <[email protected]>
@jdesrosiers
Copy link
Member

This PR can point to master instead of draft-next. It's a bugfix that can go in the patch release.

@jviotti
Copy link
Member Author

jviotti commented Dec 30, 2021

@jdesrosiers I opened a new PR that points to master here: #1170. This one can still be merged in order to fix the issue in draft-next too, right?

@jdesrosiers
Copy link
Member

This one can still be merged in order to fix the issue in draft-next too, right?

No, we're going to have to merge draft-next into master at some point and I don't want to potentially introduce conflicts by having two commits that do the same change.

@jdesrosiers jdesrosiers closed this Jan 3, 2022
Relequestual pushed a commit that referenced this pull request Jan 18, 2022
We also remove the trailing comma.

See: #1162
Signed-off-by: Juan Cruz Viotti <[email protected]>
Relequestual pushed a commit that referenced this pull request Jun 16, 2022
We also remove the trailing comma.

See: #1162
Signed-off-by: Juan Cruz Viotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants