Replace the phrase "feature set" with dialect #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't love the word "dialect" because it, to me, implies a whole new interpretation of JSON schema. I much prefer "feature set". This is just my opinion and I'm not proposing you change it back if "dialect" is the final choice. I will get behind whatever the "final choice" is. |
|
It's analogous to SQL which has different dialects. |
|
"dialect" came from me explaining this stuff to various people, including on consulting contracts. It was effective and seemed easily understood. My sample size is not huge, but there was certainly zero resistance to it. Folks noted that it fits well with "vocabulary." And @Relequestual , SQL dialects are a good analogue for explaining this, and a well-established precedent. |
|
If it works, it works. |
handrews
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it clearer that the value of $schema is a dialect identifier,