Skip to content

Add "regex" back as a format #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
handrews opened this issue Sep 2, 2017 · 1 comment
Closed

Add "regex" back as a format #392

handrews opened this issue Sep 2, 2017 · 1 comment
Labels
clarification Items that need to be clarified in the specification Priority: Low
Milestone
draft-07

Comments

@handrews
Copy link
Contributor

handrews commented Sep 2, 2017 •
edited
Loading

It's still being used in the meta-schema to describe pattern, FFS. Probably a good indication of its usefulness. Removing it was arguably a bug.
@handrews handrews added this to the draft-07 (wright-*-02) milestone Sep 2, 2017
handrews added a commit to handrews/json-schema-spec that referenced this issue Sep 8, 2017
@handrews
Restore "regex" to the list of formats.
05d2805 
Addresses json-schema-org#392.  It's come up several times that removing
this format did not make sense and was quite possibly an accident.

The "regex" format was actually still in use in the meta-schema
for "pattern".  I've added it to "patternProperties" as well
using "propertyNames".

Regular expressions are a fundamental programming tool, and
play a part in JSON Schema's specification.  It seems incorrect
to not offer semantic documentation / optional validation of them.
@handrews handrews mentioned this issue Sep 8, 2017
Merged
@handrews handrews mentioned this issue Sep 15, 2017
Merged
@handrews
Copy link
Contributor Author

Merged #398.

@gregsdennis gregsdennis moved this from Closed to Merged in Proposal: `format` update Jul 17, 2024
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Bug labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification Items that need to be clarified in the specification Priority: Low
Projects
Proposal: `format` update
Status: Closed
Milestone
draft-07
Development

No branches or pull requests
2 participants
@handrews @gregsdennis