Skip to content

Added tests for divisibleBy, format: "regex" #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2012

Conversation

timjb
Copy link
Contributor

@timjb timjb commented Oct 10, 2012

Btw, I'm using this test suite in my implementation now.

@Julian
Copy link
Member

Julian commented Oct 10, 2012

Fabulous :) glad to hear it's getting some use already, we're getting pretty close to finishing draft 3 at least.

This looks fine, other than that the schema doesn't mandate validating format (and in practice my validator and some of the other ones I know will not fail validation for format at all by default). That said, some people do like it I suppose, so perhaps we should start that optional folder that was mentioned.

Can you move (at least the invalid cases of) format.json to tests/draft3/optional/format.json?

Thanks again.

@Julian
Copy link
Member

Julian commented Oct 10, 2012

Awesome. Looks good :) thanks again.

Julian added a commit that referenced this pull request Oct 10, 2012
Added tests for divisibleBy, format: "regex"
@Julian Julian merged commit fefa4dc into json-schema-org:master Oct 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing test A request to add a test to the suite that is currently not covered elsewhere.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants