Should not parse filter values as nested filters #782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bjornharrtell, what a coincidence. I'm currently working on a major rewrite of query string parameter handling that provides way more flexible querying capabilities compared to what we offer today. In there, I already removed the comma limitation. |
|
Hopefully superceded by #792. |
|
Yes, it contains tests for using a comma inside text. Note though, you'll need to escape quotes by doubling them like this: ?filter=equals(name,'Jack O'' Brian') |
|
Superseded by #792. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where filter values can contain commas, which I noted was not accepted by current implementation.
Removing the parsing of values and special case for array filters seem a bit too invasive, however it seems to be working. I'm currently doing more evaluation of this change but would welcome input.