Code cleanup #691
Merged
Code cleanup #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 14, 2020 17:19
…erted to local variable
added 20 commits
February 17, 2020 12:20
…here the calculated value comes from is an implementation detail and should not be exposed to external code that uses paging.
…est' does not try to run tests from it
38 tasks
|
Thanks for this, will review this soon! |
maurei
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Low-hanging fruit from Resharper code quality improvement suggestions. This is not about reformatting into a uniform style, but concerns the following categories:
It is probably easiest to review each commit individually.