Skip to content

Unit test hook discovery, fix typo in hooks docs #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2019
Merged

Unit test hook discovery, fix typo in hooks docs #624

merged 3 commits into from
Nov 22, 2019

Conversation

maurei
Copy link
Member

@maurei maurei commented Nov 18, 2019 •
edited
Loading

  • Replaced all occurrences of appropiate with appropriate
  • Cleaned up hook discovery tests

@maurei maurei changed the title Hooks bugfizx Hooks bugfix Nov 18, 2019
@maurei maurei changed the title Hooks bugfix Unit test hook discovery Nov 18, 2019
@maurei maurei marked this pull request as ready for review November 18, 2019 16:19
@maurei maurei changed the title Unit test hook discovery Unit test hook discovery, fix typo in hooks docs Nov 18, 2019
@maurei
Copy link
Member Author

maurei commented Nov 18, 2019

The typo was mentioned in #623. I tried to reproduce the generic resource definition bug as described in that issue, but realised it was by design.

@maurei maurei merged commit 08b786a into master Nov 22, 2019
@maurei maurei deleted the fix/hooks-bug branch November 22, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maurei