Skip to content

Feat/#356 #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2019
Merged

Feat/#356 #466

merged 2 commits into from
Feb 2, 2019

Conversation

joshhubers
Copy link
Contributor

Closes #356

FEATURE

  • write tests that address the requirements outlined in the issue
  • fulfill the feature requirements
  • bump package version

Added a prop-docker.sh for easy docker setup while I was at it. Obviously up to you if you want to keep it.

jaredcnance
jaredcnance approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

@jaredcnance jaredcnance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jaredcnance jaredcnance merged commit a1241ee into json-api-dotnet:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredcnance jaredcnance jaredcnance approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshhubers @jaredcnance