Exact Error Codes for Error Collections #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Add 4xx error not 422 | ||
| errors.Add(new Error(401, "Unauthorized")); | ||
| Assert.Equal(400, exception.GetStatusCode()); |
|
@jaredNance what would be the timeline for this to be released? |
|
Is master the 3.0 beta or stil 2.5.1+? If we could back port this and cut a 2.5.2 that would be ❤️ |
|
@rtablada yes, and yes I will port this to a 2.5.2 release tonight |
|
Change has been backported to 2.5.2. Let me know if you run into any issues with that release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE
This change makes it so that error collections will send a status based on the status code of all items in the collection.
If the items in the collection have the same status code, then it return the status code of the entire collection.
If not, it will return 500 or 400 as before.