fix(#343): reload relationships from database if included during POST #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredcnance
commented
Aug 10, 2018
| { | ||
| foreach (var hasManyPointer in pointers) | ||
| { | ||
| await _context.Entry(hasManyPointer).ReloadAsync(); |
There was a problem hiding this comment.
this is bad
There was a problem hiding this comment.
First of all. Thank you, for this solution.
For HasMany relationships, what about something like:
_context.Entry(entity).Collection(relation).Load();
instead of:
_context.Entry(hasManyPointer).ReloadAsync();
There was a problem hiding this comment.
Thanks for the suggestion, I wasn't aware of the .Collection api. I think I like the approach I ended up taking better. The reason is that we should end up with a single SQL request that uses JOIN to load all the relationships rather than reloading each included relationship individually. I'll review it again later tonight to verify the difference.
allows changes to be rolled out in a non-breaking way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343
BUG FIX
Verified solution results in only two queries regardless of number of included relationships: