Skip to content

Revert package update of JetBrains.Annotations #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Aug 7, 2025

A bug in the latest JetBrains.Annotations package results in a runtime failure when using the newest version of JsonApiDotNetCore from nuget.org. Therefore, we're rolling back to the previous version.

Apps using JsonApiDotNetCore v5.8.0 fail at startup with the following exception:

System.IO.FileNotFoundException: 'Could not load file or assembly 'JetBrains.Annotations, Version=4242.42.42.42, Culture=neutral, PublicKeyToken=1010a0d8d6380325'. The system cannot find the file specified.'

Updating this package has always been harmless... until now! The bug is tracked at https://youtrack.jetbrains.com/issue/RSRP-501383/Could-not-load-file-or-assembly-JetBrains.Annotations-for-2025.2.0-version.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

@bkoelman bkoelman marked this pull request as ready for review August 7, 2025 23:58
@bkoelman bkoelman merged commit 4748bcc into master Aug 7, 2025
12 checks passed
@bkoelman bkoelman deleted the revert-jetbrains-update branch August 7, 2025 23:58
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.06%. Comparing base (72ae8c2) to head (ffeb5c4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1755   +/-   ##
=======================================
  Coverage   92.06%   92.06%           
=======================================
  Files         475      475           
  Lines       14699    14699           
  Branches     2322     2322           
=======================================
  Hits        13533    13533           
  Misses        765      765           
  Partials      401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant