Skip to content

Update to NSwag v14.1 #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Update to NSwag v14.1 #1600

merged 3 commits into from
Jul 19, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Jul 19, 2024

This PR updates to NSwag v14.1, which has a slightly different way of registering our partial PATCH support.
Thanks to the introduction of NSwag-specific MSBuild properties, we now distribute the required and recommended settings from our NuGet package.

Note

Don't use <Options> in <OpenApiReference> anymore, they tend to conflict with the MSBuild properties.

QUALITY CHECKLIST

@bkoelman bkoelman changed the title Update to nswag 14 Update to NSwag v14.1 Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (946c472) to head (4488a21).

Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1600      +/-   ##
===========================================
- Coverage    90.61%   90.61%   -0.01%     
===========================================
  Files          455      455              
  Lines        13604    13603       -1     
  Branches      2104     2104              
===========================================
- Hits         12327    12326       -1     
  Misses         872      872              
  Partials       405      405              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman force-pushed the update-to-nswag-14 branch from ce1e7c6 to 4488a21 Compare July 19, 2024 08:53
@bkoelman bkoelman marked this pull request as ready for review July 19, 2024 11:08
@bkoelman bkoelman merged commit be9165b into openapi Jul 19, 2024
16 checks passed
@bkoelman bkoelman deleted the update-to-nswag-14 branch July 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant