Skip to content

Improve error message when duplicate controllers found #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Improve error message when duplicate controllers found #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/JsonApiDotNetCore/Middleware/JsonApiRoutingConvention.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ public void Apply(ApplicationModel application)
{
if (_controllerPerResourceTypeMap.ContainsKey(resourceType))
{
throw new InvalidConfigurationException($"Multiple controllers found for resource type '{resourceType}'.");
throw new InvalidConfigurationException(
$"Multiple controllers found for resource type '{resourceType}': '{_controllerPerResourceTypeMap[resourceType].ControllerType}' and '{controller.ControllerType}'.");
}

_resourceTypePerControllerTypeMap.Add(controller.ControllerType, resourceType);
Expand Down
5 changes: 4 additions & 1 deletion ...otNetCoreTests/IntegrationTests/NonJsonApiControllers/DuplicateResourceControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ public void Fails_at_startup_when_multiple_controllers_exist_for_same_resource_t
Action action = () => _ = Factory;

// Assert
action.Should().ThrowExactly<InvalidConfigurationException>().WithMessage("Multiple controllers found for resource type 'knownResources'.");
InvalidConfigurationException exception = action.Should().ThrowExactly<InvalidConfigurationException>().Which!;
exception.Message.Should().StartWith("Multiple controllers found for resource type 'knownResources': ");
exception.Message.Should().Contain($"'{typeof(KnownResourcesController).FullName}'");
exception.Message.Should().Contain($"'{typeof(DuplicateKnownResourcesController).FullName}'");
}
}