Fixed crash in sort lambda from generic resource definition #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e field from its OnApplySort lambda. Where we used to special-case for Identifiable.Id, we now always use the expression type for resource graph lookups. This is safe because its not possible in C# to remove base members. The value of memberExpression.Expression is null on static member access, which is unlikely to occur in sort lambdas.
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
==========================================
- Coverage 92.58% 92.58% -0.01%
==========================================
Files 241 241
Lines 7702 7700 -2
==========================================
- Hits 7131 7129 -2
Misses 571 571
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed crash when a generic resource definition references an interface field from its
OnApplySortlambda. Where we used to special-case forIdentifiable.Id, we now always use the expression type for resource graph lookups. This is safe because its not possible in C# to remove base members. The value ofmemberExpression.Expressionis null on static member access, which is unlikely to occur in sort lambdas.Closes #1161. See the linked issue for bug repro.
QUALITY CHECKLIST