Support for Self-Referencing ManyToMany Relationships #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

askvortsov1 opened this issue Jul 9, 2020 · 3 comments · Fixed by #875

askvortsov1 commented Jul 9, 2020

Description

When trying to use HasManyThrough on a self-referencing ManyToMany relationship, an error is thrown. This is because SingleOrDefault is used to find the left and right joining properties:

JsonApiDotNetCore/src/JsonApiDotNetCore/Builders/ResourceGraphBuilder.cs

Line 160 in 9d7614f

hasManyThroughAttribute.LeftProperty = throughProperties.SingleOrDefault(x => x.PropertyType == entityType)

. A special case should be added if the property annotated by HasManyThrough is an IEnumerable of the same type as the current class.

Environment

JsonApiDotNetCore Version: v4.0.0-alpha5
Other Relevant Package Versions: Asp Net Core 3.1

Contributor

bart-degreed commented Aug 4, 2020

I'm not sure I understand how this would work. Can you post your resource class and related join type?

bart-degreed added the waiting-for-response label

Member

maurei commented Sep 4, 2020 •

edited

Loading

Closing due to inactivity. Feel free to reply with new information and we'll reconsider.

maurei closed this as completed

bart-degreed removed the waiting-for-response label

bart-degreed mentioned this issue

Write enhancements #874

Closed

Contributor

bart-degreed commented Nov 10, 2020

@askvortsov1 We have a fix for this in c0ed9a9 (part of #874).

bart-degreed mentioned this issue

Write enhancements (continued) #875

Merged

bart-degreed mentioned this issue

Self-referencing Many-to-many #915

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment