Bug: crash on invalid relationship name #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

bart-degreed opened this issue Mar 18, 2020 · 0 comments · Fixed by #714

Contributor

bart-degreed commented Mar 18, 2020

When getting a misspelled relationship name, the code crashes at CurrentRequestMiddleware.GetCurrentEntity() due to recent changes.

Repro steps:

Run the unit test Can_Get_TodoItem_WithOwner to have a record in database
Start project JsonApiDotNetCoreExample
GET http://localhost:1479/api/v1/todoItems/1?include=owner and see todoItems resource followed by included owner
GET http://localhost:1479/api/v1/todoItems/1/owner and observe successful response with person
GET http://localhost:1479/api/v1/todoItems/1/ownerX and observe HTTP 500

The text was updated successfully, but these errors were encountered:

bart-degreed mentioned this issue

Error handling and logging #714

Merged

bart-degreed closed this as completed in #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment