We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JADNC ignores any ID value in a request URL (for example: /api/v2/people/123) when using the PATCH verb. It only uses the value from the request body.
I think we should assert that both are equivalent and fail on mismatch in DefaultResourceService.UpdateAsync().
DefaultResourceService.UpdateAsync()
Also, it looks like the signature of DefaultResourceRepository.UpdateAsync was changed from:
DefaultResourceRepository.UpdateAsync
public virtual async Task<TResource> UpdateAsync(TId id, TEntity updatedEntity)
to:
public virtual async Task<TResource> UpdateAsync(TResource updatedEntity)
during development of v4. This makes it impossible to change the ID of a resource, so I think this change should be reverted.
The text was updated successfully, but these errors were encountered:
Discussed offline with @maurei. This is best solved at the formatters layer (JsonApiReader)
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
JADNC ignores any ID value in a request URL (for example: /api/v2/people/123) when using the PATCH verb. It only uses the value from the request body.
I think we should assert that both are equivalent and fail on mismatch in
DefaultResourceService.UpdateAsync()
.Also, it looks like the signature of
DefaultResourceRepository.UpdateAsync
was changed from:to:
during development of v4. This makes it impossible to change the ID of a resource, so I think this change should be reverted.
The text was updated successfully, but these errors were encountered: