Skip to content

Conversation

gnh1201
Copy link
Contributor

@gnh1201 gnh1201 commented Jul 14, 2025

The site content is WelsonJS - Build a Windows app on the Windows built-in JavaScript engine

@MattIPv4
Copy link
Member

cc #9955

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/gnh1201/welsonjs/blob/master/README.md

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Jul 14, 2025
@indus indus added the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jul 14, 2025
@indus
Copy link
Member

indus commented Jul 14, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@indus
Copy link
Member

indus commented Jul 14, 2025

I'll merge after we have "contact". Please keep this PR open.

@gnh1201
Copy link
Contributor Author

gnh1201 commented Jul 15, 2025

The website is currently displaying correctly. Thank you.

https://welson.js.org/

@indus indus removed the awaiting custom domain This PR is waiting for the GitHub Pages target to set the custom domain label Jul 15, 2025
@indus
Copy link
Member

indus commented Jul 15, 2025

Welcome https://welson.js.org

@indus indus merged commit ff288cd into js-org:master Jul 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants